Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance grommet/formfield-htmlfor-id for Select and SelectMultiple #46

Open
taysea opened this issue Jul 5, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@taysea
Copy link
Collaborator

taysea commented Jul 5, 2023

Grommet's Select/SelectMultiple component requires a different htmlFor to specifically target the underlying input. The rule should be enhanced so this isn't flagged. More specifically, it should help people know what the correct __input syntax and even add it as a quick fix.

<FormField
        htmlFor="select-example__input"
        name="select-example"
        label="Label"
      >
        <Select
          id="select-example"
          name="select-example"
          placeholder="Select item"
          options={options}
          value={selected}
          onChange={({ option }) => setSelected(option)}
        />
</FormField>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant