Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag for non-theme namespace colors #51

Open
taysea opened this issue Jul 24, 2023 · 0 comments
Open

Flag for non-theme namespace colors #51

taysea opened this issue Jul 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@taysea
Copy link
Collaborator

taysea commented Jul 24, 2023

Please describe what the rule should do:

This rule should flag when non-theme colors are used.

What category of rule is this? (place an "X" next to just one item)

[ ] Warns about a potential error (problem)
[x] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

<Text color="#453DF3" />
<Text color="skyblue" /> (where skyblue doesn't exist in the user's theme)

Why should this rule be included in eslint-plugin-grommet?

Best practice for consistency across an app to use the theme as the color namespace.

@taysea taysea added the enhancement New feature or request label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant