Skip to content

Conversation

@grosser
Copy link
Owner

@grosser grosser commented Dec 3, 2015

No description provided.

Readme.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion: Instead of maintaining the code on the wiki, put it in the code base, and require "parallel_tests/spring_config" if defined?(::Spring)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users will most likely have to reset redis + memcached + solr etc ... so
I'm afraid the solution won't work for everyone ... so something like

require 'parallel_tests/spring'
Parallel::Spring.reconnect do
ActiveRecord::Base.reconnect!
end

might be a better approach ... but that's for another PR

On Fri, Dec 4, 2015 at 6:14 AM, betesh notifications@github.com wrote:

In Readme.md
#469 (comment):

@@ -246,6 +246,7 @@ TIPS

Another suggestion: Instead of maintaining the code on the wiki, put it in
the code base, and require "parallel_tests/spring_config" if
defined?(::Spring)


Reply to this email directly or view it on GitHub
https://github.com/grosser/parallel_tests/pull/469/files#r46685247.

grosser added a commit that referenced this pull request Dec 5, 2015
allow spring to be force enabled
@grosser grosser merged commit 022181e into master Dec 5, 2015
@grosser grosser deleted the grosser/override branch December 5, 2015 03:56
@grosser
Copy link
Owner Author

grosser commented Dec 5, 2015

2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants