New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpclogger should implement LoggerV2 interface #219

Closed

kushp opened this issue Jul 12, 2019 · 2 comments

kushp commented Jul 12, 2019

Update https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/logging/zap/grpclogger.go#L20 to implement this interface https://github.com/grpc/grpc-go/blob/24b2fb8959201be9ce659bc87b0d590a34c67eae/grpclog/loggerv2.go#L30 instead of V1. Set verbosity based on GRPC_GO_LOG_VERBOSITY_LEVEL environmental variable.

I can take this on if we want to do it :)

The text was updated successfully, but these errors were encountered:

kushp mentioned this issue

Go gRPC Noisy Transport Closing Log grpc/grpc-go#2901

Closed

Author

kushp commented Jul 13, 2019

I found this #144 would love if we merge it !

Contributor

kush-patel-hs commented Jul 17, 2019 •

edited

Loading

#221 fixes this, closing, nvm I can't close, someone else can close :)

domgreen closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment