Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for new release? #533

Closed
karelbilek opened this issue Feb 7, 2023 · 8 comments
Closed

Plan for new release? #533

karelbilek opened this issue Feb 7, 2023 · 8 comments

Comments

@karelbilek
Copy link

The current release (v1.3.0) is quite old at this point

There was this issue, which hit me now, and is already solved in the master - #498 - but there might be more that I don't see.

Are there some plans for a new release?

@johanbrandhorst
Copy link
Collaborator

I believe we've mostly focused on v2, though that effort has unfortunately stalled somewhat. I don't know if we plan on making another release for v1. What do you think @bwplotka?

@aimuz
Copy link
Contributor

aimuz commented Mar 8, 2023

@johanbrandhorst What else is missing in v2 now?

@johanbrandhorst
Copy link
Collaborator

I'm frankly not sure v2 is ever going to happen at this point. I know Bartek has been very busy and just started a new job and I don't have any particular love for this project and generally recommend users don't use it. I might take some time to revamp this to be a "templates" project rather than something people use as a library, but I'm also busy with other things. I'm sorry to the users who are stuck in limbo, but as I said I generally recommend that instead of depending on this project as a library, you copy the interceptors you want to your own codebase and modify as necessary. There are too many specific use cases for a generic library like this, I think.

@karelbilek
Copy link
Author

looking at the number of "stars" and... just what I see in general, lots of people actually do use this project.

If you don't plan to make new releases, maybe mark this project as deprecated then?

I don't want to sound too snarky, it's just too much in limbo :)

@karelbilek
Copy link
Author

also I'm fine with "this is complete, we just accept bugfixes" that some projects do (like... logrus for example?), but as I linked above, there is actual memory leak fixed in master already that's not released, so that's an actual bug

@bwplotka
Copy link
Collaborator

bwplotka commented Mar 14, 2023

I actually wanted to sit down on v2 this week 🙃 Let's see if we can push this towards the finish line. The v2 is much more lightweight and allows writing your own "plugins/modules".

In the mean time I will do "last" (or one of lasts) v1 releases with right comms, no harm in that.

@bwplotka
Copy link
Collaborator

Here you go https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v1.4.0

@karelbilek
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants