Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: Inject #722

Open
loeffel-io opened this issue Aug 24, 2024 · 1 comment
Open

Logging: Inject #722

loeffel-io opened this issue Aug 24, 2024 · 1 comment

Comments

@loeffel-io
Copy link

It's almost disgusting how bad the logging is documented. There are several issues where people try to find a way to just add a single field from a grpc method to the logging finished call

Can please someone just document how to do this! I use the zap logger: https://github.com/grpc-ecosystem/go-grpc-middleware/blob/main/interceptors/logging/examples/zap/example_test.go

@johanbrandhorst
Copy link
Collaborator

Hi Lucas. There is always room for better documentation, and I encourage you to dig in and contribute. The code in this repo is very shallow and simple, so it shouldn't be too hard to figure out the parts that you're wondering about. I'm not sure how to do this myself because I haven't had a need for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants