Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

implementing the grpc-go/stats.Handler interface #36

Open
btc opened this issue Mar 9, 2018 · 3 comments
Open

implementing the grpc-go/stats.Handler interface #36

btc opened this issue Mar 9, 2018 · 3 comments

Comments

@btc
Copy link

btc commented Mar 9, 2018

Are there any plans to implement the stats.Handler interface? It exposes more information about the payload and size of data on the wire.

@mwitkow
Copy link
Member

mwitkow commented Mar 19, 2018

Oh, didn't even know about stats.Handler. However, looking at it I only see the uncompressed/compressed payload sizes as useful additional metrics. Is that your primary use case?

@btc
Copy link
Author

btc commented Mar 19, 2018

👍 Payload sizes are of interest.

However, I would read this before looking to implement the interface: grpc/grpc-go#1907 (comment)

@mwitkow
Copy link
Member

mwitkow commented Mar 20, 2018

It's probably worthwhile checking whether a wider refactor would be appropriate to see if it stats.Handler could replace the existing newServerReporter struct. Based on my experience from Stubby days, the stats structs were quite heavy, but maybe here they'll be lightweight.

@btc I'm happy to accept PRs if it's done "on the side" in an optional way. Interested in contributing?

@Bplotka for the above ^stats.Handler information (as it may be useful in kEdge).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants