Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go vet issues in template_test.go #113

Closed
shawnps opened this issue Feb 25, 2016 · 3 comments
Closed

go vet issues in template_test.go #113

shawnps opened this issue Feb 25, 2016 · 3 comments

Comments

@shawnps
Copy link
Contributor

shawnps commented Feb 25, 2016

I'm not sure what the string should be otherwise I would have made the PR myself, but there are multiple go vet issues in protoc-gen-swagger/genswagger/template_test.go:

https://goreportcard.com/report/github.com/gengo/grpc-gateway#go_vet
@shawnps
Copy link
Contributor Author

shawnps commented Feb 25, 2016

(Maybe just remove the file argument in the Errorf calls)

@achew22
Copy link
Collaborator

achew22 commented Feb 25, 2016

I'm the author on those. I absently mindedly wrote "file" in there when I wanted to write %s. Thanks for doing all this cleanup!

@shawnps
Copy link
Contributor Author

shawnps commented Feb 25, 2016

@achew22 np. If you like what I found, please consider adding a Go Report Card badge to the README 👍

[![Go Report Card](https://goreportcard.com/badge/github.com/gengo/grpc-gateway)](https://goreportcard.com/report/github.com/gengo/grpc-gateway)

@yugui yugui mentioned this issue Mar 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@achew22 @shawnps