-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base_path as constant in generated gateway files #1650
Comments
What would be the source of truth for this variable? The existing swagger annotation is not used by the gateway generator and we're unlikely to change that just for this feature. |
yes, i thought about annotation in protofile (grpc.gateway.protoc_gen_swagger.options.openapiv2_swagger).
why? |
It will be harder than you think to add this, and I don't think we want to add the maintenance cost of supporting both the http annotations and swagger annotations in the gateway generator. The swagger annotations affect only the swagger output, and not the output of the other generator, and that keeps things simpler. This feature is not important enough for us to change that. Sorry. |
if i implement it myself - will you accept this code? |
No, because it's us maintainers who have to maintain the code. I don't think this feature is important enough to;
|
🚀 Feature
Add base_path as constant in generated gateway files will be a good feature.
I try to mount two grpc services on one http router
If externalBasePath and documentsBasePath are in the generated files - it will be very useful.
The text was updated successfully, but these errors were encountered: