Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generator and descriptor packages into the public API #1877

Closed
sesposito opened this issue Dec 18, 2020 · 1 comment
Closed

Move generator and descriptor packages into the public API #1877

sesposito opened this issue Dec 18, 2020 · 1 comment

Comments

@sesposito
Copy link

Could the generator and descriptor packages be moved into the public API again in a future release please?

I've relied on them to build a custom generator and would like to upgrade it to use the protobuf v2 libs, but I'm stuck because these packages have now been made internal.

@johanbrandhorst
Copy link
Collaborator

Hi Simon, thanks for your issue. I think you'd have to make an extremely good case for us to make these public again, as they were one of the major reasons we wanted to make a v2 release. I think if you want to upgrade your generator to v2 I would recommend rewriting it in the new protogen framework, from scratch: https://pkg.go.dev/google.golang.org/protobuf@v1.25.0/compiler/protogen. If you must, we have a permissive license and as long as you include the original license you can copy the parts you want from our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants