Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS no longer works #220

Closed
jeremyje opened this issue Sep 4, 2016 · 4 comments
Closed

HTTPS no longer works #220

jeremyje opened this issue Sep 4, 2016 · 4 comments

Comments

@jeremyje
Copy link

jeremyje commented Sep 4, 2016

There's no example for HTTPS but there was https://github.com/philips/grpc-gateway-example. It no longer works with the new gRPC in TLS mode. I've tried with self signed (the example stated above) and certificates derived from a self signed CA certificate. Both give the same error.

Errors running the example.

2016/09/04 04:19:07 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: write tcp [::1]:57512->[::1]:10000: write: broken pipe"; Reconnecting to {"localhost:10000" <nil>}
2016/09/04 04:19:08 transport: http2Client.notifyError got notified that the client transport was broken unexpected EOF.
@mikelnrd
Copy link

Hi I've had the same error messages trying to get https://github.com/philips/grpc-gateway-example working with a Comodo CA certificate. Just thought I'd flag that here. My certificates work fine as an ssllabs.com test passes fine when I use the certs in a node.js app I have, hence it's definitely something golang/grpc-related. I'm afraid I'm a newbie with go so can't look into in depth.

Jeremyje - In case it's helpful, I did get https working fine by just taking the main.go from the examples folder of this repo and changing http.ListenAndServe to http.ListenAndServeTLS (and entering my .crt and .key file paths in http.ListenAndServeTLS). Hope that helps.

@kalbasit
Copy link

this is caused by a regression in Go 1.7. See philips/grpc-gateway-example@e1dfd22

@ehernandez-xk
Copy link

Now we need to explicitly enable HTTP2 when TLS is set.
This issue should be closed?

TLSConfig: &tls.Config{
  Certificates: []tls.Certificate{*demoKeyPair},
  NextProtos:   []string{"h2"},
},

@johanbrandhorst
Copy link
Collaborator

This should be closed

@achew22 achew22 closed this as completed Oct 14, 2016
@tamalsaha tamalsaha mentioned this issue Mar 30, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants