Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of "google/protobuf/descriptor.proto" #476

Closed
navygg opened this issue Oct 23, 2017 · 1 comment
Closed

Lack of "google/protobuf/descriptor.proto" #476

navygg opened this issue Oct 23, 2017 · 1 comment

Comments

@navygg
Copy link

navygg commented Oct 23, 2017

The file "third_party/googleapis/google/api/annotations.proto" line 20: import "google/protobuf/descriptor.proto";

But there is not a directory named "protobuf" under "grpc-gateway/third_party/googleapis/google" and not a file named "descriptor.proto".

Fix suggestion:
create "protobuf" directory under "grpc-gateway/third_party/googleapis/google", and copy "https://github.com/google/protobuf/tree/master/src/google/protobuf/descriptor.proto" to it.

@navygg navygg changed the title lack of "google/protobuf/descriptor.proto" Lack of "google/protobuf/descriptor.proto" Oct 23, 2017
@achew22
Copy link
Collaborator

achew22 commented Oct 23, 2017

This shouldn't be necessary. It is preferable to load those in from the protoc distribution that is where you got your protoc from to ensure no versioning issues. In the docs there is the line

protoc -I/usr/local/include -I. \
...

/usr/local/include is where I would expect those protos to live.

Please reopen if you have any more issues 😄

@achew22 achew22 closed this as completed Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants