Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor dependencies #689

Closed
jsha opened this issue Jul 2, 2018 · 3 comments
Closed

Vendor dependencies #689

jsha opened this issue Jul 2, 2018 · 3 comments
Assignees

Comments

@jsha
Copy link

jsha commented Jul 2, 2018

For the Trillian project (google/trillian#1220), I am trying to vendor all dependencies. Right now, Trillian depends on a specific version of protoc-gen-grpc-gateway. However, even if we pull that specific version, we don't currently have a good guarantee that we are getting a consistent set of dependencies pulled into protoc-gen-grpc-gateway. Would you consider vendoring this project's dependencies using dep? Vendoring represents the dependency management plan that the Go team is moving forwards with: https://blog.golang.org/versioning-proposal. Go's end goal won't be exactly like dep but will be similar, and the Go team has committed to a smooth transition.

@johanbrandhorst
Copy link
Collaborator

I'm personally in favor of just committing a Gopkg.toml and Gopkg.lock like opencensus-go did.

@tmc
Copy link
Collaborator

tmc commented Jul 7, 2018

I think going the Gopkg route as a temporary measure makes sense. @johanbrandhorst can you take that on?

@johanbrandhorst
Copy link
Collaborator

@tmc I'm on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants