Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"error" and "message" fields in error response #768

Closed
rislah opened this issue Oct 3, 2018 · 3 comments
Closed

"error" and "message" fields in error response #768

rislah opened this issue Oct 3, 2018 · 3 comments

Comments

@rislah
Copy link

rislah commented Oct 3, 2018

its being duplicated and I dont see use case for it. talking about this commit: 7951e5b. any way to get rid of it or can I just comment it out?
@johanbrandhorst
Copy link
Collaborator

We have to keep both for backwards compatibility; we may remove the "error" field in 2.0, but we cannot do it without breaking existing users for now.

@ti
Copy link
Contributor

ti commented Oct 12, 2018

add "message" fields is meaningless for now

@johanbrandhorst
Copy link
Collaborator

No, it's not meaningless, the gateway is tightly coupled with gRPC and protobuf, where the googleapis Status type is the correct way to return errors. The gateway added the message field to be more consistent with this practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johanbrandhorst @rislah @ti