Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static mapping from proto field names to golang field names #86

Closed
yugui opened this issue Jan 7, 2016 · 1 comment
Closed

Static mapping from proto field names to golang field names #86

yugui opened this issue Jan 7, 2016 · 1 comment
Labels
enhancement

Comments

@yugui
Copy link
Member

yugui commented Jan 7, 2016

As discussed in #85 (comment), runtime/query.go requires runtime mapping from proto field names to golang field names.
But the mapping rule got complicated in golang/protobuf@2c7bafc.

So it is better to generate a static mapping for each message or query fields with struct tags to keep consistency to the mapping rule.
@yugui
Copy link
Member Author

yugui commented Feb 5, 2016

#96 fixed this.
The struct tags generated by protoc-gen-go are a kind of such static mappings.

@yugui yugui closed this as completed Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yugui