Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark client no longer compiles on .NET 9 #2499

Closed
BrennanConroy opened this issue Aug 5, 2024 · 1 comment
Closed

Benchmark client no longer compiles on .NET 9 #2499

BrennanConroy opened this issue Aug 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@BrennanConroy
Copy link
Contributor

Many X509Certificate2 ctors have been marked obsolete in 9.0 and the gRPC client is using one of the obsolete APIs.

This is failing benchmark runs with the build error seen below:

/tmp/benchmarks-agent/benchmarks-server-1/6F579F9A7D95A5F7/perf/benchmarkapps/GrpcClient/Program.cs(479,45): error SYSLIB0057: 'X509Certificate2.X509Certificate2(string, string?)' is obsolete: 'Loading certificate data through the constructor or Import is obsolete. Use X509CertificateLoader instead to load certificates.' (https://aka.ms/dotnet-warnings/SYSLIB0057) [/tmp/benchmarks-agent/benchmarks-server-1/6F579F9A7D95A5F7/perf/benchmarkapps/GrpcClient/GrpcClient.csproj]
@BrennanConroy BrennanConroy added the bug Something isn't working label Aug 5, 2024
@BrennanConroy
Copy link
Contributor Author

Fixed by #2502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BrennanConroy