Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadingMessage & SendingMessage should use log level=trace #2600

Open
SaxoAnders opened this issue Feb 21, 2025 · 2 comments
Open

ReadingMessage & SendingMessage should use log level=trace #2600

SaxoAnders opened this issue Feb 21, 2025 · 2 comments

Comments

@SaxoAnders
Copy link

ReadingMessage & SendingMessage logs both use log level = debug.

This is preventing me from enabling log level = debug to analyze an issue, as that would generate too many logs.

These log levels seem inconsistent with other logs, e.g. NoMessageReturned is only log level = trace. And other debug logs are much lower volume.

So I think it would make sense to change the log level of ReadingMessage and SendingMessage to trace.

@JamesNK
Copy link
Member

JamesNK commented Feb 25, 2025

The reason ReadingMessage and SendingMessage logs are debug is so folks using streaming can set their log level to debug and still see notifications that messages are flowing between the client and server. If these logs were set to trace then they would have no feedback in the logs about messages being sent on streaming calls.

@SaxoAnders
Copy link
Author

I see. This just makes debug level rather unusable for anyone with a substantial amount of traffic.

If level was changed to trace people with low enough traffic that tracing individual messages is feasible would still have options:

  • They could change log level to trace
  • They could log in their code
  • They could look at counters

As-is debug level will create a ton of logs for people with a lot of traffic, even when everything is running smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants