Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed client using HttpClient #43

Closed
JunTaoLuo opened this issue Jan 23, 2019 · 4 comments
Closed

Managed client using HttpClient #43

JunTaoLuo opened this issue Jan 23, 2019 · 4 comments
Assignees
Labels
blocked enhancement New feature or request
Milestone

Comments

@JunTaoLuo
Copy link
Contributor

This issue tracks the work required to provide a complete managed end to end experience. This is going to be blocked on Core support for trailing response header support. cc @shirhatti for an expected timeframe.

Also, I'm not certain we need to change the code gen to implement this feature. I think we can pass in an HttpClient based call invoker to the constructor of the client. I don't have a client I can prototype this with yet so I'm not 100% certain but is there any reason this wouldn't work @jtattermusch @JamesNK ?

@JunTaoLuo JunTaoLuo added enhancement New feature or request blocked labels Jan 23, 2019
@jtattermusch
Copy link
Contributor

This issue tracks the work required to provide a complete managed end to end experience. This is going to be blocked on Core support for trailing response header support. cc @shirhatti for an expected timeframe.

Also, I'm not certain we need to change the code gen to implement this feature. I think we can pass in an HttpClient based call invoker to the constructor of the client. I don't have a client I can prototype this with yet so I'm not 100% certain but is there any reason this wouldn't work @jtattermusch @JamesNK ?

Good point, using HttpClient-based CallInvoker to create an instance of client stub should work. That should be sufficient for basic client functionality.

@JamesNK
Copy link
Member

JamesNK commented Jun 8, 2019

Initial release in preview 6. Additional features can be tracked in there own issues.

@JamesNK JamesNK closed this as completed Jun 8, 2019
@mikebm
Copy link

mikebm commented Jul 15, 2019

Sorry to resurrect this, but I am not seeing a .net standard version of the Grpc.Net.Client available in Nuget. It only targets .net core 3 which is incompatible with projects such as Xamarin Forms. Am I missing something or is this not actually available as part of preview 6.

@JamesNK
Copy link
Member

JamesNK commented Jul 15, 2019

https://www.nuget.org/packages/Grpc.Net.Client/0.1.22-pre1 - this version supports netstandard2.1

netstandard2.1 is required because the client needs to access trailers from the HTTP/2 response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants