Skip to content

Commit b599957

Browse files
committed
revert opentelemetry example
1 parent 6db15dc commit b599957

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

examples/features/csm_observability/server/main.go

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ var (
4444
prometheusEndpoint = flag.String("prometheus_endpoint", ":9464", "the Prometheus exporter endpoint")
4545
)
4646

47+
// server is used to implement helloworld.GreeterServer.
4748
type server struct {
4849
pb.UnimplementedGreeterServer
4950
addr string

examples/features/opentelemetry/client/main.go

+4-7
Original file line numberDiff line numberDiff line change
@@ -29,20 +29,17 @@ import (
2929

3030
"google.golang.org/grpc"
3131
"google.golang.org/grpc/credentials/insecure"
32-
pb "google.golang.org/grpc/examples/helloworld/helloworld"
32+
"google.golang.org/grpc/examples/features/proto/echo"
3333
"google.golang.org/grpc/stats/opentelemetry"
3434

3535
"github.com/prometheus/client_golang/prometheus/promhttp"
3636
"go.opentelemetry.io/otel/exporters/prometheus"
3737
"go.opentelemetry.io/otel/sdk/metric"
3838
)
3939

40-
const defaultName = "world"
41-
4240
var (
4341
addr = flag.String("addr", ":50051", "the server address to connect to")
4442
prometheusEndpoint = flag.String("prometheus_endpoint", ":9465", "the Prometheus exporter endpoint")
45-
name = flag.String("name", defaultName, "Name to greet")
4643
)
4744

4845
func main() {
@@ -61,14 +58,14 @@ func main() {
6158
log.Fatalf("Failed to start NewClient: %v", err)
6259
}
6360
defer cc.Close()
64-
c := pb.NewGreeterClient(cc)
61+
c := echo.NewEchoClient(cc)
6562

6663
// Make an RPC every second. This should trigger telemetry to be emitted from
6764
// the client and the server.
6865
for {
69-
r, err := c.SayHello(ctx, &pb.HelloRequest{Name: *name})
66+
r, err := c.UnaryEcho(ctx, &echo.EchoRequest{Message: "this is examples/opentelemetry"})
7067
if err != nil {
71-
log.Fatalf("Could not greet: %v", err)
68+
log.Fatalf("UnaryEcho failed: %v", err)
7269
}
7370
fmt.Println(r)
7471
time.Sleep(time.Second)

examples/features/opentelemetry/server/main.go

+7-8
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@ package main
2222
import (
2323
"context"
2424
"flag"
25+
"fmt"
2526
"log"
2627
"net"
2728
"net/http"
2829

2930
"google.golang.org/grpc"
30-
pb "google.golang.org/grpc/examples/helloworld/helloworld"
31+
pb "google.golang.org/grpc/examples/features/proto/echo"
3132
"google.golang.org/grpc/stats/opentelemetry"
3233

3334
"github.com/prometheus/client_golang/prometheus/promhttp"
@@ -40,15 +41,13 @@ var (
4041
prometheusEndpoint = flag.String("prometheus_endpoint", ":9464", "the Prometheus exporter endpoint")
4142
)
4243

43-
// server is used to implement helloworld.GreeterServer.
44-
type server struct {
45-
pb.UnimplementedGreeterServer
44+
type echoServer struct {
45+
pb.UnimplementedEchoServer
4646
addr string
4747
}
4848

49-
// SayHello implements helloworld.GreeterServer
50-
func (s *server) SayHello(_ context.Context, in *pb.HelloRequest) (*pb.HelloReply, error) {
51-
return &pb.HelloReply{Message: "Hello " + in.GetName()}, nil
49+
func (s *echoServer) UnaryEcho(_ context.Context, req *pb.EchoRequest) (*pb.EchoResponse, error) {
50+
return &pb.EchoResponse{Message: fmt.Sprintf("%s (from %s)", req.Message, s.addr)}, nil
5251
}
5352

5453
func main() {
@@ -66,7 +65,7 @@ func main() {
6665
log.Fatalf("Failed to listen: %v", err)
6766
}
6867
s := grpc.NewServer(so)
69-
pb.RegisterGreeterServer(s, &server{addr: *addr})
68+
pb.RegisterEchoServer(s, &echoServer{addr: *addr})
7069

7170
log.Printf("Serving on %s\n", *addr)
7271

0 commit comments

Comments
 (0)