xds: implement RouteAction timeout support #4116
Conversation
| } | ||
|
|
||
| func (r route) String() string { | ||
| return r.m.String() + "->" + fmt.Sprint(r.action) | ||
| return r.m.String() + "->" + fmt.Sprint(r.clusters) |
There was a problem hiding this comment.
Also print the duration? Will be hard to format though.
There was a problem hiding this comment.
Done. I thought about this earlier but forgot to do it.
I think the formatting looks good:
pathPrefix:/foo -> { clusters: [{A 1}], maxStreamDuration: 5s }
pathPrefix: -> { clusters: [{cluster_1 75} {cluster_2 25}], maxStreamDuration: 0s }
I needed to go into the WRRs to add String methods to clean this up (I broke the formatting in my previous PR since it was a map and became a WRR instance).
| } | ||
|
|
||
| func (r route) String() string { | ||
| return r.m.String() + "->" + fmt.Sprint(r.action) | ||
| return fmt.Sprintf("%s -> { clusters: %v, maxStreamDuration: %v }", r.m.String(), r.clusters, r.maxStreamDuration) |
There was a problem hiding this comment.
Add the String method to the wrr.WRR interface.
Actually, why does this work since String is not part of the interface?
There was a problem hiding this comment.
The interface is fmt.Stringer. I don't think we need to explicitly add Stringer everywhere we want to print things; it's a magic part of standard library stuff.
There was a problem hiding this comment.
Yeah, sorry. I thought you were calling String() on clusters.
| } | ||
|
|
||
| func (r route) String() string { | ||
| return r.m.String() + "->" + fmt.Sprint(r.action) | ||
| return fmt.Sprintf("%s -> { clusters: %v, maxStreamDuration: %v }", r.m.String(), r.clusters, r.maxStreamDuration) |
There was a problem hiding this comment.
Yeah, sorry. I thought you were calling String() on clusters.
This is missing one last piece from A31: reading the HTTP connection manager default max_stream_duration. I'll add that in a follow-on PR.