xds: add env var protection for client-side security #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Mar 5, 2021
xds/internal/client/xds.go
Outdated
Comment on lines
575
to
576
| sc, err = securityConfigFromCluster(cluster) | ||
| if err != nil { |
There was a problem hiding this comment.
Optional: you can combine these lines.
easwars
force-pushed
the
client_side_security_env_var
branch
from
a7fb22c
to
58b842c
Compare
easwars
force-pushed
the
client_side_security_env_var
branch
from
58b842c
to
39899c8
Compare
easwars
added
Cherry Pick
Type: Bug
and removed
Type: Internal Cleanup
menghanl
pushed a commit
to menghanl/grpc-go
that referenced
this pull request
Mar 9, 2021
menghanl
pushed a commit
to menghanl/grpc-go
that referenced
this pull request
Mar 9, 2021
This was referenced Mar 9, 2021
menghanl
added a commit
that referenced
this pull request
Mar 11, 2021
menghanl
added a commit
that referenced
this pull request
Mar 11, 2021
This was referenced Mar 12, 2021
easwars
added a commit
to easwars/grpc-go
that referenced
this pull request
Mar 25, 2021
This was referenced Mar 25, 2021
easwars
added a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never got around to protecting client-side security configuration parsing with an env var in gRPC-Go. Better late than never.
Addresses #4245
#grpc-psm-security-client-side