Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Godoc of resolver.Target #6496

Closed
philippgille opened this issue Aug 2, 2023 · 4 comments · Fixed by #6547
Closed

Update Godoc of resolver.Target #6496

philippgille opened this issue Aug 2, 2023 · 4 comments · Fixed by #6547
Labels
Status: Requires Reporter Clarification Type: Feature New features or improvements in behavior

Comments

@philippgille
Copy link
Contributor

philippgille commented Aug 2, 2023

Use case(s) - what problem will this feature solve?

It will make the Godoc consistent with the code

Proposed Solution

Recently some exported fields were removed from resolver.Target in this PR. The specific change I'd like to address is this one:
image
The Godoc still contains examples that make use of those fields.

I propose to change the Godoc to not reference the removed fields anymore, as well as to change the Endpoint one to the URL one.

Alternatives Considered

Additional Context

@philippgille philippgille added the Type: Feature New features or improvements in behavior label Aug 2, 2023
@easwars
Copy link
Contributor

easwars commented Aug 2, 2023

Thanks for filing this issue. Would you like to send a PR for the same?

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This issue is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

@github-actions github-actions bot added the stale label Aug 8, 2023
@philippgille
Copy link
Contributor Author

Thanks for filing this issue. Would you like to send a PR for the same?

Yes I can do that. Maybe on the weekend.

@philippgille
Copy link
Contributor Author

PR: #6547

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Requires Reporter Clarification Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants