Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testutils.MarshalAny #6611

Closed
easwars opened this issue Sep 8, 2023 · 1 comment · Fixed by #6617
Closed

Improve testutils.MarshalAny #6611

easwars opened this issue Sep 8, 2023 · 1 comment · Fixed by #6617
Assignees
@ulascansenturk
Labels
fixit P2 Type: Testing

Comments

@easwars
Copy link
Contributor

easwars commented Sep 8, 2023

  • Use anypb.New() instead of ptypes.MarshalAny
  • Accept a testing.T and mark this as a test helper with t.Helper() and call t.Fatalf() instead of panic
@ulascansenturk
Copy link
Contributor

Hey @easwars, you can assign me

@ulascansenturk ulascansenturk mentioned this issue Sep 11, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ulascansenturk ulascansenturk

Labels
fixit P2 Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve testutils.MarshalAny ulascansenturk/grpc-go
2 participants
@easwars @ulascansenturk