Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: TestFileWatcherCRLProviderDirectoryScan #6772

Closed
arvindbr8 opened this issue Nov 7, 2023 · 3 comments
Closed

Flaky test: TestFileWatcherCRLProviderDirectoryScan #6772

arvindbr8 opened this issue Nov 7, 2023 · 3 comments
Assignees
@erm-g
Labels
Type: Testing

Comments

@arvindbr8
Copy link
Member

Flaked in go1.21, 386

Custom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/unrevoked.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_crl.cnf": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_server_cert.key": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_client_trust_key.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_server_cert.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_client_cert.key": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_client_trust_cert.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/README.md": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_create.sh": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/revokedInt.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_client_cert.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_server_trust_key.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/revokedLeaf.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_extensions.conf": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_server_trust_cert.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/unrevoked.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_crl.cnf": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_server_cert.key": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_client_trust_key.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_server_cert.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_client_cert.key": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_client_trust_cert.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/README.md": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_create.sh": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/revokedInt.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_client_cert.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_server_trust_key.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/revokedLeaf.pem": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_extensions.conf": fail to parse CRL: x509: malformed crlCustom error message: cannot construct CRL from file "/home/runner/work/grpc-go/grpc-go/security/advancedtls/testdata/crl/provider_server_trust_cert.pem": fail to parse CRL: x509: malformed crl--- FAIL: Test (9.08s)
    --- FAIL: Test/FileWatcherCRLProviderDirectoryScan (0.01s)
        crl_provider_test.go:213: Using tmpdir: /tmp/filewatcher1134696436
        tlogger.go:116: INFO crl_provider.go:219 [advancedtls] Scan of CRLDirectory /tmp/filewatcher1134696436 completed, 1 files found and processed successfully, in-memory CRL storage flushed and repopulated  (t=+307.805µs)
        tlogger.go:116: INFO crl_provider.go:219 [advancedtls] Scan of CRLDirectory /tmp/filewatcher1134696436 completed, 2 files found and processed successfully, in-memory CRL storage flushed and repopulated  (t=+1.[371](https://github.com/grpc/grpc-go/actions/runs/6788352269/job/18453163059?pr=6720#step:8:372)622ms)
        tlogger.go:116: INFO crl_provider.go:219 [advancedtls] Scan of CRLDirectory /tmp/filewatcher1134696436 completed, 1 files found and processed successfully, in-memory CRL storage flushed and repopulated  (t=+1.570725ms)
        --- FAIL: Test/FileWatcherCRLProviderDirectoryScan/Addition_and_deletion_(2_map_entries) (0.00s)
            crl_provider_test.go:287: Parsed Cert sub = CN=Root CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub = CN=node CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub =  iss = CN=node CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:293: CRL is unexpectedly nil
            crl_provider_test.go:287: Parsed Cert sub = CN=Root CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub = CN=node CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub =  iss = CN=node CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:293: CRL is unexpectedly nil
            crl_provider_test.go:287: Parsed Cert sub = CN=Root CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub = CN=node CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub =  iss = CN=node CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:296: CRL is unexpectedly not nil
        tlogger.go:116: WARNING crl_provider.go:204 [advancedtls] Can't add CRL from file /tmp/filewatcher1134696436/README.md under CRLDirectory /tmp/filewatcher1134696436%!(EXTRA *errors.errorString=cannot construct CRL from file "/tmp/filewatcher1134696436/README.md": fail to parse CRL: x509: malformed crl)  (t=+2.880946ms)
        tlogger.go:116: INFO crl_provider.go:227 [advancedtls] Scan of CRLDirectory /tmp/filewatcher1134696436 completed, 2 files found, 1 files processing failed, 1 entries of in-memory CRL storage added/updated  (t=+2.900447ms)
        --- FAIL: Test/FileWatcherCRLProviderDirectoryScan/Addition_and_a_corrupt_file_(3_map_entries) (0.00s)
            crl_provider_test.go:287: Parsed Cert sub = CN=Root CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub = CN=node CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub =  iss = CN=node CA (2021-02-02T07:31:54-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:293: CRL is unexpectedly nil
            crl_provider_test.go:287: Parsed Cert sub = CN=Root CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub = CN=node CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub =  iss = CN=node CA (2021-02-02T07:32:57-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:293: CRL is unexpectedly nil
            crl_provider_test.go:287: Parsed Cert sub = CN=Root CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub = CN=node CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US iss = CN=Root CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
            crl_provider_test.go:287: Parsed Cert sub =  iss = CN=node CA (2021-02-02T07:30:36-08:00),OU=Production+OU=campus-sln,O=Google LLC,L=Mountain View,ST=California,C=US
        tlogger.go:116: INFO crl_provider.go:219 [advancedtls] Scan of CRLDirectory /tmp/filewatcher1134696436 completed, 0 files found and processed successfully, in-memory CRL storage flushed and repopulated  (t=+3.615658ms)
        tlogger.go:116: INFO crl_provider.go:157 [advancedtls] Scanning of CRLDirectory /tmp/filewatcher1134696436 stopped  (t=+4.215467ms)
@arvindbr8
Copy link
Member Author

https://github.com/grpc/grpc-go/actions/runs/6788352269/job/18453163059?pr=6720#logs

@arvindbr8
Copy link
Member Author

https://github.com/grpc/grpc-go/actions/runs/6778186484/job/18423225990?pr=6754

@erm-g
Copy link
Contributor

erm-g commented Nov 8, 2023

#6760 should be fixing it

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erm-g erm-g

Labels
Type: Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arvindbr8 @erm-g