Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does grpc support adding more compression algorithms #8348

Closed
skyguard1 opened this issue Jul 28, 2021 · 3 comments
Closed

Does grpc support adding more compression algorithms #8348

skyguard1 opened this issue Jul 28, 2021 · 3 comments
Labels

Comments

@skyguard1
Copy link
Contributor

In this issue #1704 discusses the issue of data compression. It seems that grpc does not intend to continue to do more work on data compression, but Compressor is used in MessageFramer.writeCompressed(), does grpc java encourage or allow the addition of more compression algorithms, such as brotli and zstd to improve compression performance, or continue to maintain the current compression algorithm without intending to do more work? thanks

@ejona86
Copy link
Member

ejona86 commented Jul 29, 2021

The current Compressor API can be used to add support for more compressors. Although this is specific to Java and not available in all languages (maybe just Go). That said, I think it was wrong to expose the API, but it hasn't been important enough to fight to remove it or fight to stabilize it.

If you are interested in other algorithms, especially brotli and zstd, I'd suggest you consider a cross-language effort. Brotli and zstd can be interesting for many users. There's a related discussion at grpc/grpc#26460, so I don't think you are alone.

@skyguard1
Copy link
Contributor Author

I understand, so more research is needed if want to add the new compression algorithm, thanks

@ejona86
Copy link
Member

ejona86 commented Jul 30, 2021

Seems like this is resolved. If not, comment, and it can be reopened.

@ejona86 ejona86 closed this as completed Jul 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants