-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Would be great if it was easy to access docs for older versions #431
Comments
What API change are you referring to ? There shouldn't have been any breaking change. |
Also, since we're not supposed to do breaking changes, always having the latest document per major version ought to be enough. |
@nicolasnoble, there's a deprecation warning on I think that a quick blurb in the README about how to build the docs yourself would be nice... However, I realized that I was following an older tutorial for authentication where the API was different: There they gave the following example: server.bind('0.0.0.0:50051', grpc.ServerCredentials.createSsl({
rootCerts: fs.readFileSync(path.join(process.cwd, "server-certs", "Snazzy_Microservices.crt")),
keyCertPairs: {
privateKey: fs.readFileSync(path.join(process.cwd, "server-certs", "login.services.widgets.inc.key")),
certChain: fs.readFileSync(path.join(process.cwd, "server-certs", "login.services.widgets.inc.crt"))
},
checkClientCertificate: true
})); It would have been nice for me to look back at previous versions and see when the api matched that tutorial, just to make sure that there were no other major changes (and if the tutorial was still valid). Just to re-iterate, having multiple builds of the docs just like the Node.js docs would be great, otherwise, an addition to the readme that instructs on how to run the build tool myself. |
Our API has never matched that code sample. In a broader scope, we published version 1.0 in late 2016, and we have not made any breaking changes since then, or in the few versions before that. I don't even know if we had generated documentation that long ago. So there is really nothing to find by looking at previous versions of the documentation. You would basically just see incomplete documentation of the current library. |
Ha! Fair enough. Thanks for the insight. |
@nicolasnoble @murgatroid99 |
That was actually not a code change. It was just a documentation error that was fixed in #171. |
Then the docs need to be updated (or republished?) then: https://grpc.io/grpc/node/grpc.ServerCredentials.html |
The new documentation has now been published. |
Is your feature request related to a problem? Please describe.
The api changed between 1.10 and 1.13... but now I can't find the api reference for 1.10. I've been looking through the code, but it's taking me way longer to find what I'm looking for than it should.
Describe the solution you'd like
Each minor release should have a separate doc build
Describe alternatives you've considered
I've just been digging through the code
Additional context
Could use some better examples around ssl with Node.js... but I think that's a much bigger ask than just keeping the old minor releases of the api docs. It could also just be that I don't know where to find them.
The text was updated successfully, but these errors were encountered: