Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-plugin image is currently broken #1449

Open
sampajano opened this issue Jun 25, 2024 · 4 comments
Open

protoc-plugin image is currently broken #1449

sampajano opened this issue Jun 25, 2024 · 4 comments

Comments

@sampajano
Copy link
Collaborator

sampajano commented Jun 25, 2024

See: #1446 (comment)

The protoc_plugin image is broken since #1445

@benjaminp FYI :)


UPDATE: Temporarily disabled in #1451

@benjaminp
Copy link
Contributor

I'm afraid I can't spend a huge amount of time digging into all ways there are to build the generator at the moment in this repo. (There's also a build.zig file in the generator directory. What's the used for?) Possibly everything should be reverted until that's in a better place.

@sampajano
Copy link
Collaborator Author

@benjaminp No worries! Appreciate your effort in trying to help anyways!!

build.zig is used for building for ARM architecture (workflow. Whereas other binaries are built using platform-specific workflows: https://github.com/grpc/grpc-web/tree/master/.github/workflows

It's ok.. I think we have to move forward anyways.. I've temporarily disabled protoc_plugin in CI so BUILD is green now. But we have to fix it for a new release to be made :)

@sampajano
Copy link
Collaborator Author

sampajano commented Jun 25, 2024

Note to myself: we are currently pinning the protobuf submodule version:

(cd third_party/protobuf && git checkout tags/v3.15.6)

This is for 2 reasons:

  1. For protobuf JS dependencies
  2. For building the generator binary

Ideally, (1) should be tackled first — by moving to https://github.com/protocolbuffers/protobuf-javascript, since protobuf has removed JS from its repo.

And then (2) — ensuring Makefile work as before.

@sampajano
Copy link
Collaborator Author

FYI - Once we have this working we can make a test binary for #715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants