VSCode Extension does not install MIPS Toolchain on MacOS

[rclement]

Describe the bug

Trying to install the MIPS Toolchain through the PSX.Dev VSCode Extension v0.3.8 on MacOS seems to be working well but keeps failing as not being installed (cannot see the final terminal output as it is auto-closing).

The mipsel-none-elf-binutils Brew Formula installs properly though.
All other tools seems to be installed and recognized fined.

Here is the state of the Tools tab after multiple install trials:

Expected behavior

The MIPS Toolchain is installed and recognized in the Tools tab (and the template creator enable the "create" buttons).

Steps to reproduce the bug

1. Install PSX.Dev VSCode Extension
2. Show Panel
3. Go to Tools tab
4. Try to install MIPS Toolchain

Operating System

MacOS 14.7 (Sonoma)

PCSX-Redux version

Version: bc029a7
Build: 107
Changeset: bc029a7
Date & time: 2024-10-24 07:41:10

CPU model

2,7 GHz Dual-Core Intel Core i5

GPU model & Drivers

Intel Iris Graphics 6100 1536 MB

BIOS version

OpenBIOS

Options

• Dynarec CPU
• 8MB
• OpenGL GPU
• Fastboot
• Debugger

Iso checks

No response

Logs

No response

Additional information

After investigating the issue, I may have found the culprit in the VSCode Extension implementation:

• The MIPS Toolchain command checks for mipsel-none-elf-g++ and mipsel-linux-gnu-g++ executable to be runnable: however both are not found in bin path after the install process
  

  pcsx-redux/tools/vscode-extension/tools.js

  Line 559 in bc029a7

  check: () => checkCommands(

• In the installToolchain command implementation for MacOS, the gccScriptPath variable actually points to the mipsel-none-elf-binutils.rb formula instead of the mipsel-none-elf-gcc.rb one!
  

  pcsx-redux/tools/vscode-extension/tools.js

  Line 136 in bc029a7

  const gccScriptPath = vscode.Uri.joinPath(

So the fix seems to be as trivial as fixing the gccScriptPath variable with the proper formula path.
Trying the fix locally on my end (by directly modifying the VSCode Extension code) is working well:

I'll submit a PR ASAP.

[rclement]

Fixed by PR #1794