Spaces in path names cause makefile to fail

[alanjds]

google#236 opened by @drgrib on 4 Feb 2017

If there is a space in the path to grumpy, there will be a long chain of errors of the type found here on make:

IOError: [Errno 2] No such file or directory: 'grumpyTest/grumpy/third_party/stdlib:/Users/credford/Dropbox/Years/__2017/__Scripts/Professional/8'
build/src/grumpy/lib/itertools/module.go:4: can't find import: "grumpy/lib/_collections"
make: *** [build/pkg/darwin_amd64/grumpy/lib/itertools.a] Error 1

Specifically, the makefile is transforming the path from

/Users/credford/Dropbox/Years/__2017/__Scripts/Professional/8 grumpyTest/grumpy/third_party/stdlib

(notice the space after the 8) to

grumpyTest/grumpy/third_party/stdlib:/Users/credford/Dropbox/Years/__2017/__Scripts/Professional/8

Changing the name of the offending folder from 8 grumpyTest to 8-grumpyTest relieved the error. You may want to make your makefile more robust for spaces in paths, though.

[alanjds]

Comment by vbmade2000
Saturday Mar 25, 2017 at 15:00 GMT

---

@drgrib Can you share the steps to reproduce same issue ?

[alanjds]

Comment by drgrib
Saturday Mar 25, 2017 at 17:22 GMT

---

@vbmade2000 I wish I could. It has been a long time since I used Grumpy and I have switched the language of my project to Go.

I can tell you that the only step required to reproduce that I think is important is that Grumpy is unzipped to a directory that has spaces in the name of one of the parent folders and then to call make on the primary Grumpy directory.

[alanjds]

Comment by vbmade2000
Sunday Mar 26, 2017 at 05:25 GMT

---

I see. I'll try to reproduce same.