Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix for #383 "Python tests does not count over make cover" #95

Open
alanjds opened this issue Oct 6, 2018 · 3 comments
Open

[WIP] Fix for #383 "Python tests does not count over make cover" #95

alanjds opened this issue Oct 6, 2018 · 3 comments
Labels
imported PR Pull Request imported from google/grumpy

Comments

@alanjds
Copy link

alanjds commented Oct 6, 2018 •
edited
Loading

google#389 opened on Dec 12, 2017 by alanjds
@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by alanjds
Wednesday Dec 13, 2017 at 19:48 GMT

build/bin/gentest:99: Bad indentation. Found 4 spaces, expected 2 (bad-indentation)

Are we using 2-spaces indent on Python code?

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by alanjds
Wednesday Jan 10, 2018 at 18:45 GMT

Hi, @BTaskaya.

Can you please take a look on google#383 (comment) if having some time? I am a bit tied for the next weeks...

Thanks for the review.

@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

Comment by ghost
Wednesday Jan 10, 2018 at 20:04 GMT

Sure.

@alanjds alanjds added the imported PR Pull Request imported from google/grumpy label Oct 6, 2018
@alanjds alanjds mentioned this issue Oct 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
imported PR Pull Request imported from google/grumpy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alanjds