-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions invisible when using Solarized (dark) theme #181
Comments
That text is invisible because the authors of Solarized Dark made the "bright black" color the same color as the background. Whoops. Also, for some reason, they made almost all of the "bright" colors not lighter, but darker than their "normal" counterparts. I'd recommend filing this as a bug with Solarized, and in the meantime, try running grunt without colors by using the |
This is easy enough to change in the iTerm preferences. Just open up the colors tab and tweak the Foreground Black Bright value to be a bit lighter. |
Thanks for the feedback to both of you. |
Solarized bug: altercation/solarized#220 |
Seeing as this has been filed as a bug now 4 times against grunt, wouldn't it be worth making the change to grunt to work around it. Sure, you can turn off colours, but that seems more like a "it's not my problem" workaround. It certainly caught me off guard, and I've not personally had any other application hit this same colour problem - so I just assumed initially there was a bug with grunt (and seeing as it's not 1.0 - it wasn't a big leap to assume that). Just saying. |
I agree with remy - Solarized is a pretty popular (if not beloved community darling) color scheme. Would it really hurt that much to tweak the color output a bit to make it work with something people like? Solarized color scheme has a pretty established set of color shades they use, and even if they push out a change now, a lot of applications that adopted it (including terminals that offer it as one of the default schemes) will remain unchanged. This means that grunt will "appear" to be broken in a lot of terminals for years even after Solarized will fix this issue on their end. Not to mention that providing unified look and feel is the primary objective of solarized. For them changing one shade is a huge deal. For grunt team on the other hand, this seems like a fairly superficial change that most users won't even notice. |
I'm re-opening this, just so I can re-close it. |
That felt good. |
I guess that's one way of acknowledging that this is a problem that neither projects (grunt & solarized) care about. Fair enough. |
It was a lot easier than me explaining all the things. But to make a long story short, as of the next version of grunt, grunt-init is a whole separate project that will probably be deprecated in favor of yeoman but is, for the meantime, kinda low on my priority list. |
Better yet, file a pull request over at grunt-init referencing this issue, and if it's really easy for me to merge, I'll do it! |
🎰 Bingo |
Ok, I know this issue is closed and it's really not a grunt.js problem but here is my quick fix for this in case someone else finds this problem the same way I did (Google Search). In iTerm2/Preferences/Profiles/Colors there is a slider bar for Minimum Contrast. Slide it from Low to High just a little and the Questions text becomes visible. |
(This is probably a problem of Solarized and not grunt, but I thought I let you know, anyway.)
Solarized (http://ethanschoonover.com/solarized) is a color scheme for terminals, featuring two color schemes. When using the dark background one, the Questions following "Please answer the following:" are completely invisible. I have to select the text in order for them to become highlighted and (barely) visible.
I'm using iTerm2 on Mac OSX.
Again, this is probably more a problem on the side of Solarized, but since it's a pretty common theme, I thought that you might like to know about it.
The text was updated successfully, but these errors were encountered: