Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a proper logger #89

Closed
robmorgan opened this issue Feb 2, 2021 · 1 comment
Closed

Use a proper logger #89

robmorgan opened this issue Feb 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@robmorgan
Copy link
Contributor

fetch currently writes directly to stdout and stderr, but we should use a proper logger. That way, we'd have log levels, logs would go to stderr, we could swap in a logger more easily that captures the output in tests, and so on.
This was referenced Feb 2, 2021
Merged
Merged
@brikis98 brikis98 added enhancement New feature or request help wanted labels Feb 3, 2021
@robmorgan
Copy link
Contributor Author

Fixed in https://github.com/gruntwork-io/fetch/releases/tag/v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robmorgan @brikis98