Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging.GetLogger does not do what we think it does #17

Open
yorinasub17 opened this issue Nov 28, 2018 · 0 comments
Open

logging.GetLogger does not do what we think it does #17

yorinasub17 opened this issue Nov 28, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@yorinasub17
Copy link
Contributor

WithField returns a logrus.Entry which contains the field information. We then return the attached Logger object, but logrus.Logger does not actually point back to the Entry. So we lose the Field information on return.
@yorinasub17 yorinasub17 added the bug Something isn't working label Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yorinasub17