Update internal TFLint version to 0.54

[velkovb]

Describe the enhancement

A clear and concise description of what the enhancement is.

Currently an old version of TFlint is used and when using an external one, the behaviour is not the same. Looking for this fix - terraform-linters/tflint#2124 as we use a lot of overrides and release 0.54 has it.

Additional context

Add any other context about the enhancement here.

Things you might want to address include:

• Changes required.
• Implications of the feature.
• Alternatives considered.
• Level of effort.

PoC (Proof of Concept)

Link to a Proof of Concept if you have one:

• PoC

Including a PoC can help others understand the feature better and implement it faster.

RFC Not Needed

• I have evaluated the complexity of this enhancement, and I believe it does not require an RFC.

[yhakbar]

Hey @velkovb ,

Thanks for creating this issue. Unfortunately, the latest release of tflint that is purely MPL licensed is v0.50.3, see v0.51.0.

I'm not a lawyer, and I don't want to have us worry about the implications of integrating directly with a product that is no longer completely open source.

I'll discuss internally with the team and see if we can give you a more satisfactory answer, but for now I would recommend integrating with the external tflint binary if you want to use a different version of tflint.

[velkovb]

Hey @yhakbar,

Thanks for the explanation. I was not aware of that but I can understand the reasons. It is sad as it was a pretty hand integration. Calling an external tflint binary doesn't behave in the same way. Will need to do some refactoring because I guess with time it will get only worse.

[tinder-tder]

We are dealing with issues where in CI/CD the newer version was updated as well as the module repo configs so now there are errors if call_module_type is configured. As @velkovb mentioned, calling external binary changes behavior (including exposing vars on the command line which can show up in logs) which doesnt work for us. The work around we are working on for now is to pass in --config and set it to a fixed older tflint config in the terragrunt repo (vs the module)

[yhakbar]

FYI, this issue will be closed with the merge of #3569 unless I fail to get that reviewed and merged.

That won't result in an update of TFLint to 0.54, or address some of the concerns raised here, but it would get us to the latest MPL version of TFLint.

[velkovb]

@yhakbar That still helps, especially with the deprecated modules attribute in the config.