Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button should return to the previous directory instead of the parent directory #2337

Closed
4 tasks done
wshoy opened this issue Jul 3, 2024 · 5 comments
Closed
4 tasks done

Comments

@wshoy
Copy link
Contributor

wshoy commented Jul 3, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a enhancement/feature request. Not a bug or question.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

The back button should return to the earlier screen, as is the case with the Samsung's file manager.
When one clicks the ".." directory and wants to go back, it's intuitive to press the back button.
To prevent a loop, the further presses will move to the parent directory.

To reproduce:

  1. Click the ".." directory
  2. Press the back button
  • Instead of the original directory you are now in the parent directory of the ".."

Information

Android version: 13
Device:
App Version: 2.12.2

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
@harshad1
Copy link
Collaborator

harshad1 commented Jul 5, 2024

I think this is the correct behavior too.

We will have to maintain a history stack.

@Asmageddon
Copy link

An option would be acceptable, but in my opinion back should always navigate up the directory tree because it's the only consistent, predictable behaviour, and going back to the previous directory is rarely useful.

@wshoy
Copy link
Contributor Author

wshoy commented Jul 12, 2024

it's the only consistent, predictable behaviour

It's not consistent with all the other apps and user expectations.

going back to the previous directory is rarely useful

I disagree. People who use "recent files" can't go back.

@gsantner
Copy link
Owner

You are welcome to make improvements.

@harshad1
Copy link
Collaborator

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants