Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight in-search results #2341

Open
4 tasks done
Benko111 opened this issue Jul 8, 2024 · 2 comments
Open
4 tasks done

Highlight in-search results #2341

Benko111 opened this issue Jul 8, 2024 · 2 comments

Comments

@Benko111
Copy link

Benko111 commented Jul 8, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a enhancement/feature request. Not a bug or question.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

  1. One of the most urgent feature for serious text processing: being able to find items you searched for by using integrated search. I use Markor predominantly for doing html/css/js drafts or quick feature drafts, stuff like that. Now it happened multiple times (enough it seems to stop here and talk about it :-)) I needed to find certain strings in minified codeblocks or just large blocks of continuous code not interrupted by any paragraphs. To find the search result without it being highlighted is basically impossible resp. equals going through the code manually. So, just as some sort of suggestion for your backlog, next time someone touches search, perhaps it would be possible and feasible to implement highlight function without having to refacture half the search code. For me, it would be a significant improvement and something I'm missing most right now. I could imagine for more people appreciating it.

Thanks for reading!

Edit: I thought it was clear, but maybe it's not: all the above written refers to edit view in plain text/html mode. It might also apply to edit modes in other file formats.

Information

Android version: n/a
Device: n/a
App Version: n/a

Source

GitHub Releases

Format / File type

Not specific

Additional info / Log

-
@harshad1
Copy link
Collaborator

harshad1 commented Jul 8, 2024

This would be a view mode feature, right?

@Benko111
Copy link
Author

Benko111 commented Jul 8, 2024

No, as specified in my edit above I'm talking about edit mode!

Edit:

Talking about View Mode (always in plain text/html section), I don't use search function very much when viewing, cos copying from View Mode is noticeably delayed and lacks responsiveness. That's why I got used to use search in Edit Mode mostly. Important to know: I'm talking about page sizes of above 50.000 characters, often up to a megabyte. Those sizes are generally forcing me to deactivate code highlight and auto format, which is a shame, but then it's rapid and fully responsive, so no biggy living with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants