-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 SAFARI: Select and Autocomplete's overlay don't have the correct size on Safari. #908
Comments
I agree that this is a bug, at least it's non breaking since the options are visible and actionnable. |
The polyfill we are currently using seem pretty much dead. No action at all for a while, should we eventually move to https://github.com/juggle/resize-observer who supports borderBoxSize and contentBoxSize and seems somehow more maintained? From what I read the migration is not a lot of work. |
@alexasselin008 any opinions? |
Another suggestion would be investigating if we can move away from borderBoxSize.
|
This has been fixed on Safari side, testes on Safari Version 15.6.1 (17613.3.9.1.16) and no error in the console, the width is good too. |
Describe the bug
When using Safari, the select and autocomplete component display the following error in the console:
TypeError: undefined is not an object (evaluating '$(e.borderBoxSize)[0].inlineSize')
This code is used in the useTriggerWidth's code.
This is due to the fact that the resize-observer-polyfill doesn't have a polyfill for the borderBoxSize and contentBoxSize's properties, as per issue que-etc/resize-observer-polyfill#77.
Steps to reproduce
On Safari, open a page with a select or autocomplete control. Notice the error in the console.
The width of the overlay is also different:
expected :
Expected results
The overlay's width should be the same as the trigger.
The text was updated successfully, but these errors were encountered: