Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ways of removing circular dependencies #412

Open
mesozoic opened this issue Nov 24, 2024 · 0 comments · May be fixed by #414
Open

Investigate ways of removing circular dependencies #412

mesozoic opened this issue Nov 24, 2024 · 0 comments · May be fixed by #414

Comments

@mesozoic
Copy link
Collaborator

There are a number of type annotations that create circular dependencies in the library, which triggered #411. That particular issue is being resolved upstream in Pydantic, but it's conceivable that this could cause other issues with other libraries or toolchains in the future.

The way we've set up the class hierarchy (where all contained classes have a reference to their parents, so everything has access to an Api instance) it's not clear how we would remove the circular type annotations. But I'll leave this here in case anyone has an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant