Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critical in accessible::tests::test_accessible_update_state #1889

Open
felinira opened this issue Oct 26, 2024 · 2 comments
Open

critical in accessible::tests::test_accessible_update_state #1889

felinira opened this issue Oct 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@felinira
Copy link
Contributor

Bug description

Running accessible::tests::test_accessible_update_state causes a critical that looks a little concerning.

Maybe it could be useful to set fatal criticals in tests? Or would that cause too many flaky tests?

test accessible::tests::test_accessible_update_state ... ok

(process:1000119): GLib-GObject-CRITICAL **: 18:07:29.862: g_value_get_pointer: assertion 'G_VALUE_HOLDS_POINTER (value)' failed
@felinira felinira added the bug Something isn't working label Oct 26, 2024
@sdroege
Copy link
Member

sdroege commented Oct 26, 2024

Generally a good idea to make criticals fatal and we do that in gtk-rs-core (I hope!) and gstreamer-rs (definitely)

@felinira
Copy link
Contributor Author

I wanted to get a backtrace and now I can't reproduce it anymore. sigh.

Feel free to close if you can't either, I've been doing too much stuff with my screenreader today that might have messed up gtk in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants