Fix jruby error on Pathname#relative_path_from #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… binary encoding before substitute. because Pathname#relative_path_from behaves different in JRuby
thibaudgg
added a commit
that referenced
this pull request
May 21, 2013
Fix jruby error on Pathname#relative_path_from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fault on #115
Go back to the regexp substitution and force both path and directory encodings before substitution.
The regexp is a bit different (need more specs?):
^match line begin, should be\Afor string begin#{File::SEPARATOR}?may get path "/ab" recognized as "b" under directory "/a"