Make Listen::Listener capable of listening to multiple directories #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having just PS: Stats seems to be broken... :) |
|
Thanks, you probably meant specs are broken! ;-) @Maher4Ever any opinion about this PR? |
|
@rymai please rebase on master and we should be good to go with 0.8.0 :) |
It also deprecates Listen::MultiListener since all the logic has been generalized and moved to Listen::Listener.
|
Done! |
ghost
assigned
thibaudgg
added a commit
that referenced
this pull request
Apr 8, 2013
Make Listen::Listener capable of listening to multiple directories
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that the logic in
Listen::MultiListenerhad nothing very specific and could be generalized directly inListen::Listener.It also deprecates
Listen::MultiListenersince all the logic has beengeneralized and moved to
Listen::Listener.What do you think of this?