Default high precision off if the mtime call fails #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudgg
added a commit
that referenced
this pull request
Jan 6, 2013
Default high precision off if the mtime call fails
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an edge case. When using the gem under JRuby inside a JAR on Windows, the mtime call fails with SystemCallError unknown error 20047.
I assume that this is because it's run under a JAR archive and Windows does something different from OSX that makes the mtime call fail. It works fine under OSX, and I imagine Linux as well.
Since it's a bit of an edge case, and the alternative I see is to hook it into the listen test in
works?, I figured it's better to just default to high precision not being available if it errors.