Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compression #1

Open
nicl opened this issue Apr 22, 2022 · 2 comments
Open

Support compression #1

nicl opened this issue Apr 22, 2022 · 2 comments

Comments

@nicl
Copy link
Contributor

nicl commented Apr 22, 2022

Update: it surprises me, but actually no-one has really requested this feature in practice. I guess it's easy enough to compress things yourself. Please 👍 this issue though if you would find it helpful.

node-riffraff-artifact supports zip and tar compression. More generally, it is a useful feature for a build process.

I can see this being used in various projects, e.g.

https://github.com/guardian/dotcom-rendering/blob/main/apps-rendering/artifact.json#L8
https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/scripts/deploy/build-riffraff-bundle.js#L30

We should add this, probably with an extra property that would live alongside sources, called something like compression.

@Mark-McCracken
Copy link
Contributor

Just looking at migrating some build pipeline from teamcity to GHA for globe-phan.
In this case, only really got 2 files to upload, but they need to be zipped, so a simple option to zip the contents of every folder could be a way.
However I've also seen some complex builds for dotcom that have about 8 folders, and some contents are zipped, some aren't, they're .deb files, so we might need a more complex way for the user to define the behaviour

@JuliaBrigitte
Copy link
Contributor

Today there was a discussion about this in the DevX Channel, there definitely should be something about compression in the README. @davidfurey pointed up two different ways of zipping (directly in yml/ in package.json) in addition to running a script like this in the yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants