Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate keyboard navigation to popover #26

Closed
jonathonherbert opened this issue Jan 2, 2025 · 0 comments
Closed

Delegate keyboard navigation to popover #26

jonathonherbert opened this issue Jan 2, 2025 · 0 comments

Comments

@jonathonherbert
Copy link
Collaborator

At the moment, the plugin manipulates the popover option index with imperative methods on the TypeaheadPopover class, which in turn passes index values to the popover renderer.

This approach means that handling more complex navigation — for example, tab navigation to swap between relative and absolute dates — couples the TypeaheadPopover (which does not know what it's rendering) with the rendered components, which will soon have opinions about what they'd like to happen when left, right and enter are pressed.

We should delegate navigation to the renderer, allowing the renderer to subscribe to navigation events, and triggering them from the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant