What do we call our rendering apps? #8990
Closed
jamesgorrie
started this conversation in
RFCs
Replies: 2 comments 2 replies
-
Could we keep the |
Beta Was this translation helpful? Give feedback.
1 reply
-
Could we remove the
|
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently we have 1 app to rule them all. We are in the process of trying to split these out to avoid a single point of failure.
There are a few name we have in our deployment are:
frontend-cfn
- the CloudFront for our 1 apprendering
- the name for the artefact deployed to S3 and then via Riff Raff to EC2DotcomRendering-{env}.template.json
- the CloudFormation template name${stack}-${stage}-${app}-ELB
the name of the load balancer that fronts this app (limit 32 characters)In this PR we suggest the following name pattern:
{app}-cfn
- for the cloudfront deployment{app}
- for the artefact deploymentDotcomRendering-{app}-{env}.template.json
for the CloudFormation template name${stack}-${stage}-${app}-ELB
- the load balancer nameThe example for
render-front
would be:render-front-cfn
- for the cloudfront deploymentrender-front
- for the artefact deploymentDotcomRendering-render-front-CODE.template.json
for the CloudFormation template namefrontend-CODE-render-front-ELB
- the load balancer nameThis seems to fit quite nicely, and it is almost the same as what we have for other naming conventions in the code which also take rendering target AKA
web | apps
into account e.g. render.article.web which is quite nice.If we want to stick to this convention completely, all would work well, except for the fact that the 32 character limit on the ELBs (which also apply to ALBs, so isn't solved by updating 😞) would catch us e.g.
frontend-CODE-render-front-web-ELB
frontend-CODE-render-article-web-ELB
As this feels like a time to try and get some naming right I have opened up this discussion to see what people or if they have some suggestion around how we might scale this given we know we will be adding more apps to the stack.
Beta Was this translation helpful? Give feedback.
All reactions