Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Pasting a note between two paragraphs containing notes #163

Open
shaundillon opened this issue Jan 23, 2017 · 0 comments
Open

Pasting a note between two paragraphs containing notes #163

shaundillon opened this issue Jan 23, 2017 · 0 comments
Labels

Comments

@shaundillon
Copy link

shaundillon commented Jan 23, 2017

To reproduce:

  • Create 2 paragraphs and add a note to each:
    picture 71
  • Copy some text containing a note and paste that as a new paragraph between the existing ones:
    picture 72

Effect:
A new note is created from the start of the copied note, through to the end of the last note.

I've done some investigation into this and here are my findings:
in generate-note-controller the isPasteInsideNote function checks if you're pasting content inside a note, and then calls wrap-in-note-around-paste if this is the case. This is incorrectly assuming you're pasting inside a note.

There is a branch with a scribe instance and noting set up here: https://github.com/guardian/scribe/tree/sd-fix-noting

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant