Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

UndoManager and transaction documentation #485

Open
mindplay-dk opened this issue Jun 13, 2016 · 0 comments
Open

UndoManager and transaction documentation #485

mindplay-dk opened this issue Jun 13, 2016 · 0 comments

Comments

@mindplay-dk
Copy link

Inline documentation for UndoManager transactions is more or less non-existent.

What exactly are the transaction objects?

It appears to be an overloaded version of DOMTransaction, e.g. with several custom properties, including scribe, content and previousItem.

And it doesn't look like the scribe property is being used? (the advanced undo plugin doesn't seem to use them either.)

Under some conditions, _lastItem gets initialized as a full instance of one of these overloaded DOMTransaction objects, and at other times, it's as simple as { content: '' }, which does appear to be valid, as all properties of DOMTransaction are optional, but with no doc-blocks and no comments, it's all very difficult to reason about.

Can you provide some pointers in this area?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant