You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.
Inline documentation for UndoManager transactions is more or less non-existent.
What exactly are the transaction objects?
It appears to be an overloaded version of DOMTransaction, e.g. with several custom properties, including scribe, content and previousItem.
And it doesn't look like the scribe property is being used? (the advanced undo plugin doesn't seem to use them either.)
Under some conditions, _lastItem gets initialized as a full instance of one of these overloaded DOMTransaction objects, and at other times, it's as simple as { content: '' }, which does appear to be valid, as all properties of DOMTransaction are optional, but with no doc-blocks and no comments, it's all very difficult to reason about.
Can you provide some pointers in this area?
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Inline documentation for UndoManager transactions is more or less non-existent.
What exactly are the transaction objects?
It appears to be an overloaded version of
DOMTransaction
, e.g. with several custom properties, includingscribe
,content
andpreviousItem
.And it doesn't look like the
scribe
property is being used? (the advanced undo plugin doesn't seem to use them either.)Under some conditions,
_lastItem
gets initialized as a full instance of one of these overloadedDOMTransaction
objects, and at other times, it's as simple as{ content: '' }
, which does appear to be valid, as all properties ofDOMTransaction
are optional, but with no doc-blocks and no comments, it's all very difficult to reason about.Can you provide some pointers in this area?
The text was updated successfully, but these errors were encountered: