Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypting does not complete - divide by zero #47

Open
PseudoFIame opened this issue May 13, 2022 · 1 comment
Open

Encrypting does not complete - divide by zero #47

PseudoFIame opened this issue May 13, 2022 · 1 comment
Assignees

Comments

@PseudoFIame
Copy link

I tried to use this app with a sample picture (square sizes JPEG, each pixel same color; see attached gray.jpg), however the app does not complete. All attempted encryptions fail at around 76%. Clicking on redo takes some time, but fails again.

Tried both v1.01 in F-droid store, as well v1.02 from this repo.

Logs indicate a divide-by-zero problem:

$ adb logcat
...
05-13 05:43:40.156 24616 25288 D JPEG-STEGO: Embedding of 768 bits (92+4 bytes) 
05-13 05:43:40.156 24616 25288 D JPEG-STEGO: using default code, file will not fit
05-13 05:43:43.976 24616 25288 E JPEG-STEGO: java.lang.ArithmeticException: divide by zero
05-13 05:43:43.976 24616 25288 W System.err: java.lang.ArithmeticException: divide by zero
05-13 05:43:43.976 24616 25288 W System.err: 	at info.guardianproject.f5android.plugins.f5.james.JpegEncoder.WriteCompressedData(JpegEncoder.java:592)
05-13 05:43:43.976 24616 25288 W System.err: 	at info.guardianproject.f5android.plugins.f5.james.JpegEncoder.Compress(JpegEncoder.java:101)
05-13 05:43:43.976 24616 25288 W System.err: 	at info.guardianproject.f5android.plugins.f5.james.JpegEncoder.Compress(JpegEncoder.java:126)
05-13 05:43:43.977 24616 25288 W System.err: 	at info.guardianproject.pixelknot.StegoEncryptionJob$3.run(StegoEncryptionJob.java:94)
05-13 05:43:43.977 24616 25288 W System.err: 	at info.guardianproject.pixelknot.StegoJob$1.run(StegoJob.java:79)

sample picture:
gray

@n8fr8
Copy link
Member

n8fr8 commented Jun 1, 2022

Thank you for testing and for the sample image. Will reproduce and try to fix.

@n8fr8 n8fr8 self-assigned this Jun 1, 2022
@n8fr8 n8fr8 added this to the Summer Pixel Love milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants