Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small TextView is broken scrolling using scrollbar #2761

Closed
chr1st0scli opened this issue Jul 20, 2023 · 4 comments · Fixed by #2770
Closed

Small TextView is broken scrolling using scrollbar #2761

chr1st0scli opened this issue Jul 20, 2023 · 4 comments · Fixed by #2770
Labels

Comments

@chr1st0scli
Copy link

Describe the bug
A notably small TextView cannot be scrolled correctly using a scrollbar.

This bug relates to #2688 which is corrected. I am mentioning it here because it might need a regression test after this one is corrected.

To Reproduce
Steps to reproduce the behavior:

  1. Add a quite short TextView, so that you don't have to insert a lot of text to reproduce the error.
  2. Set it's ReadOnly property to true and its Text property to several lines, such that they exceed its height. Note that @BDisp had noted that the text view being a read only has nothing to do with the problem.
  3. Attach a vertical scrollbar to it as demonstrated in the UI catalog.
  4. Scroll down to the end using the keyboard arrow keys (I do it programmatically in the screenshot) and then try to scroll up again, by clicking on the scrollbar's arrows or using the mouse's middle button.
  5. Notice that you cannot scroll back to the top.

Expected behavior
To scroll correctly.

Screenshots
Below I am demonstrating the inability to scroll using the scrollbar and the ability to scroll using the keyboard arrow keys with no problem. The bigger TextView above does not suffer from the same problem.

ScrollbarProblem

Desktop (please complete the following information):

  • OS: Windows
  • Version 10
@BDisp
Copy link
Collaborator

BDisp commented Jul 26, 2023

@chr1st0scli can you test the fix in the #2770, please? Thanks.

@tig tig changed the title Small TextView's broken scrolling using scrollbar Small TextView is broken scrolling using scrollbar Jul 26, 2023
@chr1st0scli
Copy link
Author

@BDisp yes, sure.

I see that we didn't make it for 1.13.5, yes?

@chr1st0scli
Copy link
Author

@BDisp everything works on this PR!

@BDisp
Copy link
Collaborator

BDisp commented Jul 26, 2023

I see that we didn't make it for 1.13.5, yes?

Yes, but I'm sure that @tig will publish after this is merged. But I want to do some more unit tests to prevents this doesn't break in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants