Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GetEvals explode() calls #67

Open
guidopetri opened this issue Nov 9, 2021 · 0 comments
Open

Clean up GetEvals explode() calls #67

guidopetri opened this issue Nov 9, 2021 · 0 comments
Labels
help wanted Extra attention is needed refactor

Comments

@guidopetri
Copy link
Owner

Right now the positions/evaluations/eval depths get exploded separately in GetEvals which causes a bunch of issues (namely, what happens if there is a position but no evaluation for it?). It would be far better to have these list-likes exploded together instead of separately, but I think this requires a restructuring of a bunch of the visitors code (or getting the game infos).

@guidopetri guidopetri added help wanted Extra attention is needed refactor labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed refactor
Projects
None yet
Development

No branches or pull requests

1 participant